Chromium Code Reviews| Index: src/runtime-profiler.h |
| diff --git a/src/runtime-profiler.h b/src/runtime-profiler.h |
| index 7f2c9024bf10f3cbd21eba3fff5ab77d0d0a1005..8059e4331af8a8ab5768e6568bcc7358a25b85ce 100644 |
| --- a/src/runtime-profiler.h |
| +++ b/src/runtime-profiler.h |
| @@ -13,6 +13,7 @@ namespace internal { |
| class Isolate; |
| class JavaScriptFrame; |
| class JSFunction; |
| +enum class OptimizationReason : uint8_t; |
| class RuntimeProfiler { |
| public: |
| @@ -30,8 +31,14 @@ class RuntimeProfiler { |
| int frame_count); |
| void MaybeBaselineIgnition(JSFunction* function, JavaScriptFrame* frame); |
| void MaybeOptimizeIgnition(JSFunction* function, JavaScriptFrame* frame); |
| - void Optimize(JSFunction* function, const char* reason); |
| - void Baseline(JSFunction* function, const char* reason); |
| + // Potentially attempts OSR from ignition and returns whether no other |
| + // optimization attempts should be made |
|
rmcilroy
2016/09/23 08:10:34
fullstops on comments, and newline before the comm
klaasb
2016/09/23 08:31:40
The comment is mostly about the intended semantics
|
| + bool MaybeOSRIgnition(JSFunction* function, JavaScriptFrame* frame); |
| + void Optimize(JSFunction* function, OptimizationReason reason); |
| + // Decides whether to optimize the function from Ignition and for what reason |
| + OptimizationReason OptimizationHeuristicIgnition(JSFunction* function, |
|
rmcilroy
2016/09/23 08:10:34
nit - ShouldOptimizeIgnition(...) and move either
klaasb
2016/09/23 08:31:40
Done.
|
| + JavaScriptFrame* frame); |
| + void Baseline(JSFunction* function, OptimizationReason reason); |
| Isolate* isolate_; |
| bool any_ic_changed_; |