[interpreter] Compute and use type info percentage

src/runtime-profiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_RUNTIME_PROFILER_H_
 #define V8_RUNTIME_PROFILER_H_
 
 #include "src/allocation.h"
 
 namespace v8 {
 namespace internal {
 
 class Isolate;
 class JavaScriptFrame;
 class JSFunction;
+enum class OptimizationReason : uint8_t;
 
 class RuntimeProfiler {
  public:
   explicit RuntimeProfiler(Isolate* isolate);
 
   void MarkCandidatesForOptimization();
 
   void NotifyICChanged() { any_ic_changed_ = true; }
 
   void AttemptOnStackReplacement(JavaScriptFrame* frame,
                                  int nesting_levels = 1);
 
  private:
   void MaybeOptimizeFullCodegen(JSFunction* function, JavaScriptFrame* frame,
                                 int frame_count);
   void MaybeBaselineIgnition(JSFunction* function, JavaScriptFrame* frame);
   void MaybeOptimizeIgnition(JSFunction* function, JavaScriptFrame* frame);
-  void Optimize(JSFunction* function, const char* reason);
-  void Baseline(JSFunction* function, const char* reason);
+  // Potentially attempts OSR from ignition and returns whether no other
+  // optimization attempts should be made

[rmcilroy, 2016/09/23 08:10:34]

fullstops on comments, and newline before the comment (also, not sure if
comments are needed here given they are private functions).

[klaasb, 2016/09/23 08:31:40]

The comment is mostly about the intended semantics for the bool return value.

+  bool MaybeOSRIgnition(JSFunction* function, JavaScriptFrame* frame);
+  void Optimize(JSFunction* function, OptimizationReason reason);
+  // Decides whether to optimize the function from Ignition and for what reason
+  OptimizationReason OptimizationHeuristicIgnition(JSFunction* function,

[rmcilroy, 2016/09/23 08:10:34]

nit - ShouldOptimizeIgnition(...) and move either above Optimise or below
Baseline

[klaasb, 2016/09/23 08:31:40]

Done.

+                                                   JavaScriptFrame* frame);
+  void Baseline(JSFunction* function, OptimizationReason reason);
 
   Isolate* isolate_;
   bool any_ic_changed_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_RUNTIME_PROFILER_H_