Issue 23609064: Make "three snapshot technique" work on heap snapshots loaded from files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23609064: Make "three snapshot technique" work on heap snapshots loaded from files (Closed)

Created:
7 years, 3 months ago by yurys

Modified:
7 years, 3 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make "three snapshot technique" work on heap snapshots loaded from files This changes allows to show objects created between two selected heap snapshots in the case when the snapshots have been loaded from files. BUG=154084 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158273

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -66 lines)			Patch
M	LayoutTests/inspector-protocol/cpu-profiler/record-cpu-profile.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/inspector/profiler/cpu-profiler-save-load.html	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorHeapProfilerAgent.cpp	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	Source/core/inspector/InspectorProfilerAgent.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/devtools/front_end/CPUProfileView.js	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshot.js	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotProxy.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotView.js	View	4 chunks	+12 lines, -13 lines	0 comments	Download
M	Source/devtools/front_end/JSHeapSnapshot.js	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/ProfilesPanel.js	View	5 chunks	+5 lines, -11 lines	0 comments	Download
M	Source/devtools/front_end/ProfilesPanelDescriptor.js	View	1 chunk	+1 line, -27 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 3 months ago (2013-09-24 14:33:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r158273 (presubmit successful).

Expand Messages | Collapse Messages