Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: Source/devtools/front_end/CPUProfileView.js

Issue 23609064: Make "three snapshot technique" work on heap snapshots loaded from files (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorProfilerAgent.cpp ('k') | Source/devtools/front_end/HeapSnapshot.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/CPUProfileView.js
diff --git a/Source/devtools/front_end/CPUProfileView.js b/Source/devtools/front_end/CPUProfileView.js
index 745dc84e5a2913aea19c50a7e0e4eb231ba644f4..81070446eb1b6fd378370c6c82812f761e3becdb 100644
--- a/Source/devtools/front_end/CPUProfileView.js
+++ b/Source/devtools/front_end/CPUProfileView.js
@@ -749,7 +749,7 @@ WebInspector.CPUProfileType.prototype = {
removeProfile: function(profile)
{
WebInspector.ProfileType.prototype.removeProfile.call(this, profile);
- if (!profile.isTemporary)
+ if (!profile.isTemporary && !profile.fromFile())
ProfilerAgent.removeProfile(this.id, profile.uid);
},
@@ -919,11 +919,10 @@ WebInspector.CPUProfileHeader.prototype = {
},
/**
- * @param {File} file
+ * @param {!File} file
*/
loadFromFile: function(file)
{
- this.title = file.name;
this.sidebarElement.subtitle = WebInspector.UIString("Loading\u2026");
this.sidebarElement.wait = true;
« no previous file with comments | « Source/core/inspector/InspectorProfilerAgent.cpp ('k') | Source/devtools/front_end/HeapSnapshot.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698