Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2360833002: Only anchor along the block layout axis. (Closed)

Created:
4 years, 3 months ago by skobes
Modified:
4 years, 3 months ago
Reviewers:
Finnur, ymalik
CC:
chromium-reviews, extensions-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, chromium-apps-reviews_chromium.org, kinuko+watch, ojan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only anchor along the scroller's block layout axis. Also update corner selection to use the style of the scroller, not that of the anchor node, for consistency. BUG=646977 Committed: https://crrev.com/f347a360168703ac909eee252afbdd79849354ca Cr-Commit-Position: refs/heads/master@{#420329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -15 lines) Patch
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchor.cpp View 4 chunks +16 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 2 chunks +60 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
skobes
4 years, 3 months ago (2016-09-21 22:03:46 UTC) #5
ymalik
lgtm, thanks
4 years, 3 months ago (2016-09-21 22:43:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360833002/1
4 years, 3 months ago (2016-09-21 23:37:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/264342)
4 years, 3 months ago (2016-09-21 23:46:50 UTC) #12
skobes
+bokan for OWNERS
4 years, 3 months ago (2016-09-21 23:49:16 UTC) #14
skobes
make that +rdevlin.cronin for OWNERS
4 years, 3 months ago (2016-09-21 23:50:27 UTC) #16
skobes
+finnur for OWNERS?
4 years, 3 months ago (2016-09-22 04:15:14 UTC) #18
Finnur
extension_settings_browsertest.js LGTM
4 years, 3 months ago (2016-09-22 11:29:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360833002/1
4 years, 3 months ago (2016-09-22 14:07:13 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 14:12:57 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 14:19:42 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f347a360168703ac909eee252afbdd79849354ca
Cr-Commit-Position: refs/heads/master@{#420329}

Powered by Google App Engine
This is Rietveld 408576698