Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

Issue 2360833002: Only anchor along the block layout axis. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ScrollAnchor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
index ecf35ddeca0d0eb3517608740181f08d27c2d00f..1aca91b8c5da4bd2ea5e2c856167b8d1cc81060e 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
+++ b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
@@ -323,11 +323,8 @@ TEST_F('AutoScrollExtensionSettingsWebUITest', 'testAutoScroll', function() {
assertEquals(0, document.body.scrollTop);
this.nextStep();
};
- var scrollToOrigin = function() {
- // Reset both top and left to avoid a scroll anchoring adjustment when the
- // #dev-controls element is inserted (crbug.com/646977).
+ var scrollToTop = function() {
document.body.scrollTop = 0;
- document.body.scrollLeft = 0;
this.nextStep();
};
// Test that a) autoscroll works on first page load and b) updating the
@@ -335,7 +332,7 @@ TEST_F('AutoScrollExtensionSettingsWebUITest', 'testAutoScroll', function() {
this.steps = [this.waitForPageLoad,
checkHasScrollbar,
checkIsScrolled,
- scrollToOrigin,
+ scrollToTop,
this.enableDeveloperMode,
checkScrolledToTop,
testDone];
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ScrollAnchor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698