Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 236083002: Linux sandbox: style cleanup for setuid sandbox. (Closed)

Created:
6 years, 8 months ago by jln (very slow on Chromium)
Modified:
6 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Linux sandbox: style cleanup for setuid sandbox. R=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263695

Patch Set 1 #

Patch Set 2 : Also fix header inclusions. Ohh goodness. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -55 lines) Patch
M sandbox/linux/suid/client/setuid_sandbox_client.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M sandbox/linux/suid/client/setuid_sandbox_client_unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M sandbox/linux/suid/common/suid_unsafe_environment_variables.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/suid/linux_util.c View 1 4 chunks +6 lines, -4 lines 0 comments Download
M sandbox/linux/suid/process_util.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M sandbox/linux/suid/process_util_linux.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/suid/sandbox.c View 1 12 chunks +37 lines, -40 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jln (very slow on Chromium)
Robert, could you PTAL?
6 years, 8 months ago (2014-04-11 22:34:31 UTC) #1
Robert Sesek
lgtm
6 years, 8 months ago (2014-04-14 13:57:34 UTC) #2
jln (very slow on Chromium)
6 years, 8 months ago (2014-04-14 19:29:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r263695 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698