sandbox/linux/suid/common/suid_unsafe_environment_variables.h - Issue 236083002: Linux sandbox: style cleanup for setuid sandbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/suid/common/suid_unsafe_environment_variables.h

Issue 236083002: Linux sandbox: style cleanup for setuid sandbox. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Also fix header inclusions. Ohh goodness. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/suid/common/suid_unsafe_environment_variables.h

diff --git a/sandbox/linux/suid/common/suid_unsafe_environment_variables.h b/sandbox/linux/suid/common/suid_unsafe_environment_variables.h

index 1132a7a71615acf4faf5b8d3a0cb6e8e9d0c08dc..33ba4b6ab723535563f91af2dcacc60e0848c541 100644

--- a/sandbox/linux/suid/common/suid_unsafe_environment_variables.h

+++ b/sandbox/linux/suid/common/suid_unsafe_environment_variables.h

@@ -54,7 +54,7 @@ static inline char* SandboxSavedEnvironmentVariable(const char* envvar) {

const size_t envvar_len = strlen(envvar);

const size_t kMaxSizeT = (size_t) -1;

- if (envvar_len > kMaxSizeT - 1 -8)

+ if (envvar_len > kMaxSizeT - 1 - 8)

return NULL;

const size_t saved_envvarlen = envvar_len + 1 /* NUL terminator */ +