instrumentation tests: Stop passing a generator to posixpath.join()

instrumentation tests: Stop passing a generator to posixpath.join()

Commit d4d66d4d ("Reland #2: Move side-loaded test data /sdcard ->
/sdcard/gtestdata") introduced a regression in
LocalDeviceInstrumentationTestRun.substitute_device_root() when it's
passed a list: the posixpath.join() call ends up receiving a generator
instead of multiple arguments.

This means the call will return a generator instead of 'foo/bar/baz',
which is not what's intended.

R=jbudorick@chromium.org

Committed: https://crrev.com/37ac2516dde8b3fb2647880c406961a9cf052c65
Cr-Commit-Position: refs/heads/master@{#420101}

[Raphael Kubo da Costa (rakuco), 2016-09-21 15:43:32]

PTAL.

It's also possible to just remove the isinstance(d, list) block altogether, as I
think that was only being used by the --test-data code path that got removed in
https://codereview.chromium.org/2131083003

[jbudorick, 2016-09-21 15:50:54]

lgtm

[Raphael Kubo da Costa (rakuco), 2016-09-21 15:51:59]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2016-09-21 15:52:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 18:01:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 18:03:18]

Description was changed from

==========
instrumentation tests: Stop passing a generator to posixpath.join()

Commit d4d66d4d ("Reland #2: Move side-loaded test data /sdcard ->
/sdcard/gtestdata") introduced a regression in
LocalDeviceInstrumentationTestRun.substitute_device_root() when it's
passed a list: the posixpath.join() call ends up receiving a generator
instead of multiple arguments.

This means the call will return a generator instead of 'foo/bar/baz',
which is not what's intended.

R=jbudorick@chromium.org
==========

to

==========
instrumentation tests: Stop passing a generator to posixpath.join()

Commit d4d66d4d ("Reland #2: Move side-loaded test data /sdcard ->
/sdcard/gtestdata") introduced a regression in
LocalDeviceInstrumentationTestRun.substitute_device_root() when it's
passed a list: the posixpath.join() call ends up receiving a generator
instead of multiple arguments.

This means the call will return a generator instead of 'foo/bar/baz',
which is not what's intended.

R=jbudorick@chromium.org

Committed: https://crrev.com/37ac2516dde8b3fb2647880c406961a9cf052c65
Cr-Commit-Position: refs/heads/master@{#420101}
==========

[commit-bot: I haz the power, 2016-09-21 18:03:21]

Patchset 1 (id:??) landed as
https://crrev.com/37ac2516dde8b3fb2647880c406961a9cf052c65
Cr-Commit-Position: refs/heads/master@{#420101}