Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 2131083003: [Android] Remove the --test_data option from the test runner. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove the --test_data option from the test runner. All suites now use isolate files that are either generated from gn data / data_deps or checked in to chromium. BUG= Committed: https://crrev.com/e17088df1d6f3cab29c0c817d7f71def8a84841e Cr-Commit-Position: refs/heads/master@{#404488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -36 lines) Patch
M build/android/buildbot/bb_device_steps.py View 4 chunks +3 lines, -9 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 3 chunks +1 line, -20 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
Depends on a downstream CL.
4 years, 5 months ago (2016-07-08 17:39:11 UTC) #2
rnephew (Reviews Here)
On 2016/07/08 17:39:11, jbudorick wrote: > Depends on a downstream CL. lgtm
4 years, 5 months ago (2016-07-08 21:05:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131083003/1
4 years, 5 months ago (2016-07-08 21:09:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 21:14:38 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 21:14:40 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 21:17:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e17088df1d6f3cab29c0c817d7f71def8a84841e
Cr-Commit-Position: refs/heads/master@{#404488}

Powered by Google App Engine
This is Rietveld 408576698