Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 236063014: Revert 263647 "Revert 263644 "[DevTools] Touch emulation in cont..." (Closed)

Created:
6 years, 8 months ago by dgozman
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 263647 "Revert 263644 "[DevTools] Touch emulation in cont..." Static initializers issue was fixed in r263789. > Revert 263644 "[DevTools] Touch emulation in content." > > Reason for revert: broke > http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/63653/ > by introducing two new static-initializers into the chrome binary: > # velocity_tracker.cc ui::(anonymous namespace)::LeastSquaresVelocityTrackerStrategy::HORIZON > # velocity_tracker.cc ui::(anonymous namespace)::ASSUME_POINTER_STOPPED_TIME > > > [DevTools] Touch emulation in content. > > > > When renderer requests touch emulation using mouse, host creates > > a TouchEmulator object and passes mouse, mouse wheel and keyboard events > > to emulator before sending them to renderer. > > > > Emulator completely blocks mouse-related events, and instead generates > > touch events. Those touch events are handled over to gesture provider > > after being acked by renderer. Resulting gestures are sent to the renderer. > > > > When shift is pressed, scroll gestures are converted to pinch gestures, so > > user can scale the page. This is required because multitouch is not yet > > supported by emulator. > > > > BUG=337142 > > > > Review URL: https://codereview.chromium.org/138163016 > > TBR=dgozman@chromium.org > > Review URL: https://codereview.chromium.org/237353003 TBR=fischman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -7 lines) Patch
A + trunk/src/content/browser/renderer_host/input/touch_emulator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/touch_emulator.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/touch_emulator_client.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/renderer_host/input/touch_emulator_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_impl.h View 7 chunks +13 lines, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_impl.cc View 11 chunks +47 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_unittest.cc View 9 chunks +242 lines, -9 lines 0 comments Download
A + trunk/src/content/browser/resources/devtools/devtools_pinch_cursor.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/resources/devtools/devtools_touch_cursor.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/child/blink_platform_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/common/view_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/content/content_browser.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/content/content_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/renderer/devtools/devtools_agent.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/renderer/devtools/devtools_agent.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dgozman
6 years, 8 months ago (2014-04-15 08:57:53 UTC) #1
dgozman
6 years, 8 months ago (2014-04-15 09:00:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r263806.

Powered by Google App Engine
This is Rietveld 408576698