Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 237353003: Revert 263644 "[DevTools] Touch emulation in content." (Closed)

Created:
6 years, 8 months ago by Ami GONE FROM CHROMIUM
Modified:
6 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 263644 "[DevTools] Touch emulation in content." Reason for revert: broke http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/63653/ by introducing two new static-initializers into the chrome binary: # velocity_tracker.cc ui::(anonymous namespace)::LeastSquaresVelocityTrackerStrategy::HORIZON # velocity_tracker.cc ui::(anonymous namespace)::ASSUME_POINTER_STOPPED_TIME > [DevTools] Touch emulation in content. > > When renderer requests touch emulation using mouse, host creates > a TouchEmulator object and passes mouse, mouse wheel and keyboard events > to emulator before sending them to renderer. > > Emulator completely blocks mouse-related events, and instead generates > touch events. Those touch events are handled over to gesture provider > after being acked by renderer. Resulting gestures are sent to the renderer. > > When shift is pressed, scroll gestures are converted to pinch gestures, so > user can scale the page. This is required because multitouch is not yet > supported by emulator. > > BUG=337142 > > Review URL: https://codereview.chromium.org/138163016 TBR=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1138 lines) Patch
D trunk/src/content/browser/renderer_host/input/touch_emulator.h View 1 chunk +0 lines, -100 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/touch_emulator.cc View 1 chunk +0 lines, -371 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/touch_emulator_client.h View 1 chunk +0 lines, -26 lines 0 comments Download
D trunk/src/content/browser/renderer_host/input/touch_emulator_unittest.cc View 1 chunk +0 lines, -318 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_impl.h View 7 chunks +1 line, -13 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_impl.cc View 11 chunks +3 lines, -47 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_unittest.cc View 9 chunks +9 lines, -242 lines 0 comments Download
D trunk/src/content/browser/resources/devtools/devtools_pinch_cursor.png View Binary file 0 comments Download
D trunk/src/content/browser/resources/devtools/devtools_touch_cursor.png View Binary file 0 comments Download
M trunk/src/content/child/blink_platform_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/common/view_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/content/content_browser.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/content_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/renderer/devtools/devtools_agent.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/renderer/devtools/devtools_agent.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ami GONE FROM CHROMIUM
6 years, 8 months ago (2014-04-14 17:26:42 UTC) #1
Ami GONE FROM CHROMIUM
Committed patchset #1 manually as r263647 (tree was closed).
6 years, 8 months ago (2014-04-14 17:27:46 UTC) #2
jdduke (slow)
On 2014/04/14 17:27:46, Ami Fischman wrote: > Committed patchset #1 manually as r263647 (tree was ...
6 years, 8 months ago (2014-04-14 17:47:26 UTC) #3
jdduke (slow)
6 years, 8 months ago (2014-04-15 04:47:47 UTC) #4
Message was sent while issue was closed.
On 2014/04/14 17:47:26, jdduke wrote:
> On 2014/04/14 17:27:46, Ami Fischman wrote:
> > Committed patchset #1 manually as r263647 (tree was closed).
> 
> Ah, I can take care of the issue, thanks.

Fix has been stalled in the CQ because of other flakes, should land soon...
https://codereview.chromium.org/233433005/

Powered by Google App Engine
This is Rietveld 408576698