Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 236063009: Fixes misleading error message when compiling dart

Created:
6 years, 8 months ago by Sam E
Modified:
6 years, 8 months ago
Reviewers:
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fixes misleading error message when compiling dart Issue 18218 There are 2 test cases to test this fix: 1. Expected behaviour: JDK is not installed. - run the following: export JAVA_HOME=/non-existing-place python2.7 -c 'import compile_analyzer; compile_analyzer.VerifyJavacGetPath()' unset JAVA_HOME 2. Unexpected bahaviour (python2.6): python2.6 -c 'import compile_analyzer; compile_analyzer.VerifyJavacGetPath()' Trailing whitespace clean up. BUG=18218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M editor/tools/compile_analyzer.py View 1 chunk +3 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698