Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: editor/tools/compile_analyzer.py

Issue 236063009: Fixes misleading error message when compiling dart Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/compile_analyzer.py
diff --git a/editor/tools/compile_analyzer.py b/editor/tools/compile_analyzer.py
index 53bd00916f69f5551bdc5e6bef6bf92a2c8c76ad..5fdb399f708ff073d3683967b86794b5df33ecd1 100644
--- a/editor/tools/compile_analyzer.py
+++ b/editor/tools/compile_analyzer.py
@@ -96,11 +96,12 @@ def VerifyJavacGetPath():
javac_path = GetJavacPath()
try:
subprocess.check_output([javac_path, "-version"])
- except:
+ except (OSError, subprocess.CalledProcessError), e:
print "You do not have JDK installed, can't build the analyzer"
+ print "Reason: %s" % e
exit(1)
return javac_path
-
+
def GetJavacPath():
if 'JAVA_HOME' in os.environ:
return join(os.environ['JAVA_HOME'], 'bin',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698