dart/sdk/lib/_internal/compiler/implementation/scanner/partial_parser.dart - Issue 23606010: Fix various parser bugs related to modifiers of top-level and class members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/scanner/partial_parser.dart

Issue 23606010: Fix various parser bugs related to modifiers of top-level and class members. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/warnings.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/scanner/partial_parser.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/scanner/partial_parser.dart b/dart/sdk/lib/_internal/compiler/implementation/scanner/partial_parser.dart

index 3b666ae53d796e9e451068d1b7247de2a5f37394..80544872ebd69b9a7dfb8761b0371a7e4249be90 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/scanner/partial_parser.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/scanner/partial_parser.dart

@@ -95,10 +95,13 @@ class PartialParser extends Parser {

return endGroup;

}

- Token parseFunctionBody(Token token, bool isExpression) {

+ Token parseFunctionBody(Token token, bool isExpression, bool allowAbstract) {

assert(!isExpression);

String value = token.stringValue;

if (identical(value, ';')) {

+ if (!allowAbstract) {

+ listener.reportError(token, MessageKind.BODY_EXPECTED);

+ }

// No body.

} else if (identical(value, '=>')) {

token = parseExpression(token.next);