dart/sdk/lib/_internal/compiler/implementation/patch_parser.dart - Issue 23606010: Fix various parser bugs related to modifiers of top-level and class members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/patch_parser.dart

Issue 23606010: Fix various parser bugs related to modifiers of top-level and class members. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart » ('j') | dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/patch_parser.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/patch_parser.dart b/dart/sdk/lib/_internal/compiler/implementation/patch_parser.dart

index 5ae57794030dc75662656f0e3ef541b17df0ed27..d21e842a6a29b9209e0da108080db7bd7cee1b89 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/patch_parser.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/patch_parser.dart

@@ -401,6 +401,7 @@ void patchElement(leg.DiagnosticListener listener,

origin.isConstructor() ||

origin.isFunction() ||

origin.isAbstractField())) {

+ // TODO(ahe): Remove this error when the parser rejects all bad modifiers.

listener.reportError(origin, leg.MessageKind.PATCH_NONPATCHABLE);

return;

}

@@ -415,6 +416,7 @@ void patchElement(leg.DiagnosticListener listener,

} else if(patch.isFunction()) {

tryPatchFunction(listener, origin, patch);

} else {

+ // TODO(ahe): Remove this error when the parser rejects all bad modifiers.

listener.reportError(patch, leg.MessageKind.PATCH_NONPATCHABLE);

}