exo: Implement minimal support for version 6 of XDG shell.

exo: Implement minimal support for version 6 of XDG shell.

ShellSurface::Configure is now able to handle the case where |widget_|
is null as XDG shell version 6 requires the client to commit state
prior to providing contents and making the shell surface visible.

BUG=648028
Review-Url: https://codereview.chromium.org/2360533002
Cr-Commit-Position: refs/heads/master@{#447164}
Committed: https://chromium.googlesource.com/chromium/src/+/189f9f6663dda6f7bb8a0e7639dbd0f9fc2e1a6b

[reveman, 2016-10-15 00:49:55]

reveman@chromium.org changed reviewers:
+ dcastagna@chromium.org

[Daniele Castagna, 2016-10-20 20:09:16]

LGTM

https://codereview.chromium.org/2360533002/diff/20001/components/exo/shell_su...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2360533002/diff/20001/components/exo/shell_su...
components/exo/shell_surface.cc:1104: if (widget_) {
Can you mention in the CL description why the widget_ can now be nullptr?

[reveman, 2017-01-30 22:53:53]

Description was changed from

==========
exo: Implement minimal support for version 6 of XDG shell.

BUG=648028
==========

to

==========
exo: Implement minimal support for version 6 of XDG shell.

ShellSurface::Configure is now able to handle the case where |widget_|
is null as XDG shell version 6 requires the client to commit state
prior to providing contents and making the shell surface visible.

BUG=648028
==========

[reveman, 2017-01-30 22:54:05]

https://codereview.chromium.org/2360533002/diff/20001/components/exo/shell_su...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2360533002/diff/20001/components/exo/shell_su...
components/exo/shell_surface.cc:1104: if (widget_) {
On 2016/10/20 at 20:09:16, Daniele Castagna wrote:
> Can you mention in the CL description why the widget_ can now be nullptr?

Done.

[reveman, 2017-01-30 22:54:08]

The CQ bit was checked by reveman@chromium.org

[reveman, 2017-01-30 22:54:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dcastagna@chromium.org
Link to the patchset: https://codereview.chromium.org/2360533002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-30 22:54:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 00:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 00:19:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[reveman, 2017-01-31 00:51:28]

The CQ bit was checked by reveman@chromium.org

[reveman, 2017-01-31 00:51:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dcastagna@chromium.org
Link to the patchset: https://codereview.chromium.org/2360533002/#ps60001
(title: "fix bad rebase and unit tests")

[commit-bot: I haz the power, 2017-01-31 00:51:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 02:15:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485823888267220,
"parent_rev": "da667f7e960637d2531cf0306fbc2137633e1773", "commit_rev":
"189f9f6663dda6f7bb8a0e7639dbd0f9fc2e1a6b"}

[commit-bot: I haz the power, 2017-01-31 02:16:27]

Description was changed from

==========
exo: Implement minimal support for version 6 of XDG shell.

ShellSurface::Configure is now able to handle the case where |widget_|
is null as XDG shell version 6 requires the client to commit state
prior to providing contents and making the shell surface visible.

BUG=648028
==========

to

==========
exo: Implement minimal support for version 6 of XDG shell.

ShellSurface::Configure is now able to handle the case where |widget_|
is null as XDG shell version 6 requires the client to commit state
prior to providing contents and making the shell surface visible.

BUG=648028

Review-Url: https://codereview.chromium.org/2360533002
Cr-Commit-Position: refs/heads/master@{#447164}
Committed:
https://chromium.googlesource.com/chromium/src/+/189f9f6663dda6f7bb8a0e7639db...
==========

[commit-bot: I haz the power, 2017-01-31 02:16:28]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/189f9f6663dda6f7bb8a0e7639db...