[heap] Make typed slot set state and operations atomic.

[heap] Make typed slot set state and operations atomic.

BUG=chromium:648568
Committed: https://crrev.com/6f06c36c3e1ecb41f1d301ad2159366f876d53c8
Cr-Commit-Position: refs/heads/master@{#39596}

[Hannes Payer (out of office), 2016-09-21 10:27:46]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 10:27:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 10:55:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 10:55:32]

Dry run: This issue passed the CQ dry run.

[ulan, 2016-09-21 11:52:34]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2016-09-21 11:52:35]

lgtm with comments

https://codereview.chromium.org/2360513002/diff/40001/src/heap/slot-set.h
File src/heap/slot-set.h (right):

https://codereview.chromium.org/2360513002/diff/40001/src/heap/slot-set.h#new...
src/heap/slot-set.h:326: bool added = new_top_chunk->AddSlot(slot);
Nit: how about swapping the order of these two operations: add slot and then set
the chunk_?

https://codereview.chromium.org/2360513002/diff/40001/src/heap/slot-set.h#new...
src/heap/slot-set.h:353: Address host_addr = page_start_ +
buffer[i].host_offset();
As discussed offline, we need to change order of loads here.

[Hannes Payer (out of office), 2016-09-21 12:14:15]

https://codereview.chromium.org/2360513002/diff/40001/src/heap/slot-set.h
File src/heap/slot-set.h (right):

https://codereview.chromium.org/2360513002/diff/40001/src/heap/slot-set.h#new...
src/heap/slot-set.h:326: bool added = new_top_chunk->AddSlot(slot);
On 2016/09/21 11:52:35, ulan wrote:
> Nit: how about swapping the order of these two operations: add slot and then
set
> the chunk_?

Done.

https://codereview.chromium.org/2360513002/diff/40001/src/heap/slot-set.h#new...
src/heap/slot-set.h:353: Address host_addr = page_start_ +
buffer[i].host_offset();
On 2016/09/21 11:52:35, ulan wrote:
> As discussed offline, we need to change order of loads here.

Done.

We could also change it to only read out the word with the type once. However,
that would lift the low level representation to that method, which is not nice.

[Hannes Payer (out of office), 2016-09-21 12:48:26]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 12:48:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-09-21 12:57:49]

The CQ bit was unchecked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-09-21 12:57:52]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-09-21 12:57:53]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2360513002/#ps120001
(title: "remove include")

[commit-bot: I haz the power, 2016-09-21 12:58:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 13:20:43]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-21 13:21:01]

Description was changed from

==========
[heap] Make typed slot set state and operations atomic.

BUG=chromium:648568
==========

to

==========
[heap] Make typed slot set state and operations atomic.

BUG=chromium:648568

Committed: https://crrev.com/6f06c36c3e1ecb41f1d301ad2159366f876d53c8
Cr-Commit-Position: refs/heads/master@{#39596}
==========

[commit-bot: I haz the power, 2016-09-21 13:21:03]

Patchset 7 (id:??) landed as
https://crrev.com/6f06c36c3e1ecb41f1d301ad2159366f876d53c8
Cr-Commit-Position: refs/heads/master@{#39596}