Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Unified Diff: android_webview/browser/render_thread_manager.cc

Issue 2360423003: aw: Fix FBO restore in webview functor (Closed)
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/render_thread_manager.cc
diff --git a/android_webview/browser/render_thread_manager.cc b/android_webview/browser/render_thread_manager.cc
index 71327783ead520ea52553d5abe4b32461dac017a..f05e7c072ddd00a4b59dab876334049aa9f77fa9 100644
--- a/android_webview/browser/render_thread_manager.cc
+++ b/android_webview/browser/render_thread_manager.cc
@@ -286,20 +286,10 @@ void RenderThreadManager::DrawGL(AwDrawGLInfo* draw_info) {
draw_info->mode == AwDrawGLInfo::kModeDraw
? ScopedAppGLStateRestore::MODE_DRAW
: ScopedAppGLStateRestore::MODE_RESOURCE_MANAGEMENT);
- // Set the correct FBO before kModeDraw. The GL commands run in kModeDraw
- // require a correctly bound FBO. The FBO remains until the next kModeDraw.
- // So kModeProcess between kModeDraws has correctly bound FBO, too.
- if (hardware_renderer_) {
- hardware_renderer_->SetBackingFrameBufferObject(
- state_restore.framebuffer_binding_ext());
- }
-
ScopedAllowGL allow_gl;
if (!hardware_renderer_ && draw_info->mode == AwDrawGLInfo::kModeDraw &&
!IsInsideHardwareRelease() && HasFrameForHardwareRendererOnRT()) {
hardware_renderer_.reset(new HardwareRenderer(this));
- hardware_renderer_->SetBackingFrameBufferObject(
- state_restore.framebuffer_binding_ext());
hardware_renderer_->CommitFrame();
}
@@ -323,7 +313,7 @@ void RenderThreadManager::DrawGL(AwDrawGLInfo* draw_info) {
}
if (hardware_renderer_)
- hardware_renderer_->DrawGL(draw_info, state_restore);
+ hardware_renderer_->DrawGL(draw_info);
DeferredGpuCommandService::GetInstance()->PerformIdleWork(false);
}
« no previous file with comments | « android_webview/browser/parent_output_surface.cc ('k') | android_webview/browser/scoped_app_gl_state_restore.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698