Implement OffscreenCanvas Unaccelerated 2d commit() on main thread

content/test/gpu/page_sets/pixel_tests.py

Index: content/test/gpu/page_sets/pixel_tests.py
diff --git a/content/test/gpu/page_sets/pixel_tests.py b/content/test/gpu/page_sets/pixel_tests.py
index 28bf9b4ed254b93118d4cbddd6faa5104ef0d1dd..449d934c47c6141bb6bea2383822fd4e644f65f9 100644
--- a/content/test/gpu/page_sets/pixel_tests.py
+++ b/content/test/gpu/page_sets/pixel_tests.py
@@ -48,6 +48,15 @@ class IOSurface2DCanvasSharedPageState(gpu_test_base.GpuSharedPageState):
       ['--enable-accelerated-2d-canvas',
        '--disable-display-list-2d-canvas'])
 
+class SoftwareOffscreenCanvas2DSharedPageState(
+        gpu_test_base.GpuSharedPageState):
+  def __init__(self, test, finder_options, story_set):
+    super(SoftwareOffscreenCanvas2DSharedPageState, self).__init__(
+      test, finder_options, story_set)
+    finder_options.browser_options.AppendExtraBrowserArgs(
+      ['--disable-accelerated-2d-canvas',
+       '--disable-gpu-compositing',
+       '--enable-experimental-canvas-features'])
 
 class WebGLNonChromiumImageSharedPageState(gpu_test_base.GpuSharedPageState):
   def __init__(self, test, finder_options, story_set):
@@ -211,6 +220,15 @@ class PixelTestsStorySet(story_set_module.StorySet):
       expectations=expectations))
 
     self.AddStory(PixelTestsPage(
+      url='file://../../data/gpu/pixel_acceleratedOffscreen2d_commit_main.html',
+      name=base_name + '.OffscreenCanvasUnaccelerated2D' + es3_suffix,
+      test_rect=[0, 0, 350, 350],
+      revision=1,
+      story_set=self,
+      shared_page_state_class=SoftwareOffscreenCanvas2DSharedPageState,
+      expectations=expectations))

[Ken Russell (switch to Gerrit), 2016/09/26 22:29:30]

Could you put this in __init__ instead, after the call to
self._AddAllPages(expectations, base_name, False)? As in Xida's
https://codereview.chromium.org/2365653005/ , since this test requires a special
SharedPageState, it won't run in both ES2 and ES3 modes anyway so doesn't need
to be in this block.

[xlai (Olivia), 2016/09/29 15:53:07]

Done.

+
+    self.AddStory(PixelTestsPage(
       url='file://../../data/gpu/pixel_canvas2d.html',
       name=base_name + '.Canvas2DRedBox' + es3_suffix,
       test_rect=[0, 0, 300, 300],