Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 23604050: Namespace internal extension JavaScript modules with extensions:: so that they (Closed)

Created:
7 years, 3 months ago by not at google - send to devlin
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Devlin
Visibility:
Public.

Description

Namespace internal extension JavaScript modules with extensions:: so that they can be identified in stack traces, and filtered out when showing to developers. BUG=21734 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222149

Patch Set 1 #

Patch Set 2 : add size() #

Patch Set 3 : c_str #

Patch Set 4 : utf8value #

Patch Set 5 : utf8value 2 #

Patch Set 6 : Error Console Tests Fixed (uploaded by rdevlin.cronin) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M chrome/browser/extensions/error_console/error_console_browsertest.cc View 1 2 3 4 5 5 chunks +13 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/module_system.cc View 1 2 3 4 5 chunks +11 lines, -5 lines 0 comments Download
M extensions/common/extension_urls.cc View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
not at google - send to devlin
7 years, 3 months ago (2013-09-09 18:24:11 UTC) #1
koz (OOO until 15th September)
lgtm
7 years, 3 months ago (2013-09-09 18:35:23 UTC) #2
not at google - send to devlin
devlin showed me in v8.h that AsciiValue is deprecated so I've changed it do use ...
7 years, 3 months ago (2013-09-09 18:44:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/23604050/9001
7 years, 3 months ago (2013-09-09 18:45:34 UTC) #4
commit-bot: I haz the power
Failed to trigger a try job on linux_rel HTTP Error 400: Bad Request
7 years, 3 months ago (2013-09-09 18:45:38 UTC) #5
not at google - send to devlin
Oops replaced the wrong one. Ah well might as well do them all.
7 years, 3 months ago (2013-09-09 18:45:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/23604050/12001
7 years, 3 months ago (2013-09-09 18:46:13 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=75358
7 years, 3 months ago (2013-09-09 21:30:54 UTC) #8
not at google - send to devlin
lgtm devlin's fix to his tests :)
7 years, 3 months ago (2013-09-09 21:56:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/23604050/15004
7 years, 3 months ago (2013-09-09 21:56:30 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 00:22:19 UTC) #11
Message was sent while issue was closed.
Change committed as 222149

Powered by Google App Engine
This is Rietveld 408576698