Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: extensions/common/extension_urls.cc

Issue 23604050: Namespace internal extension JavaScript modules with extensions:: so that they (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Error Console Tests Fixed (uploaded by rdevlin.cronin) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/module_system.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extension_urls.cc
diff --git a/extensions/common/extension_urls.cc b/extensions/common/extension_urls.cc
index 38a1fff0ea656a8c5d33245618e7d3d0c4725530..ba72a63ef21971225eb3a4d124d569a57e223a9f 100644
--- a/extensions/common/extension_urls.cc
+++ b/extensions/common/extension_urls.cc
@@ -4,6 +4,7 @@
#include "extensions/common/extension_urls.h"
+#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "extensions/common/constants.h"
#include "url/gurl.h"
@@ -16,8 +17,9 @@ const char kSchemaUtils[] = "schemaUtils";
bool IsSourceFromAnExtension(const base::string16& source) {
return GURL(source).SchemeIs(kExtensionScheme) ||
- source == base::UTF8ToUTF16(kEventBindings) ||
- source == base::UTF8ToUTF16(kSchemaUtils);
+ StartsWith(source,
+ base::ASCIIToUTF16("extensions::"),
+ true /* case-sensitive */);
}
} // namespace extensions
« no previous file with comments | « chrome/renderer/extensions/module_system.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698