Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 23604020: Initial prototype of object layout generation.

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
6 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Initial prototype of object layout generation. R=

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+993 lines, -446 lines) Patch
M Makefile View 2 chunks +6 lines, -0 lines 1 comment Download
M src/objects.h View 5 chunks +5 lines, -217 lines 0 comments Download
A src/objects.layout View 1 chunk +153 lines, -0 lines 2 comments Download
M src/objects-debug.cc View 4 chunks +0 lines, -64 lines 0 comments Download
A src/objects-gen.h View 1 chunk +366 lines, -0 lines 0 comments Download
A src/objects-gen.cc View 1 chunk +229 lines, -0 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects-printer.cc View 4 chunks +0 lines, -105 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + tools/objects-gen.cc.mustache View 1 chunk +35 lines, -26 lines 0 comments Download
A + tools/objects-gen.h.mustache View 1 chunk +57 lines, -32 lines 0 comments Download
A tools/objects-generator.py View 1 chunk +137 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-09-02 07:59:04 UTC) #1
titzer
https://codereview.chromium.org/23604020/diff/1/src/objects.layout File src/objects.layout (right): https://codereview.chromium.org/23604020/diff/1/src/objects.layout#newcode56 src/objects.layout:56: { name: "value", comment: "the boxed contents." }, I ...
7 years, 3 months ago (2013-09-02 08:32:10 UTC) #2
Jakob Kummerow
https://codereview.chromium.org/23604020/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/23604020/diff/1/Makefile#newcode241 Makefile:241: .PHONY: all check clean dependencies $(ENVFILE).new native \ Should ...
7 years, 3 months ago (2013-09-03 12:20:05 UTC) #3
titzer
6 years, 11 months ago (2014-01-28 09:34:00 UTC) #4
On 2013/09/03 12:20:05, Jakob wrote:
> https://codereview.chromium.org/23604020/diff/1/Makefile
> File Makefile (right):
> 
> https://codereview.chromium.org/23604020/diff/1/Makefile#newcode241
> Makefile:241: .PHONY: all check clean dependencies $(ENVFILE).new native \
> Should add objects here (and, while you're at it, grokdump)

(Removed myself from this review to shorten my review list; add me back at the
next round).

Powered by Google App Engine
This is Rietveld 408576698