[Telemetry] Implement dirty profile generation

[Telemetry] Implement dirty profile generation

Teach generation_profiles to actually generate a dirty profile and download it off a device.

BUG=136664
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220157

[tonyg, 2013-08-28 00:09:58]

This is super clean. I like it.

lgtm

https://codereview.chromium.org/23604005/diff/8001/tools/perf/profile_creator...
File tools/perf/profile_creators/small_profile_creator.py (right):

https://codereview.chromium.org/23604005/diff/8001/tools/perf/profile_creator...
tools/perf/profile_creators/small_profile_creator.py:23: return not
page.page_set.pages.index(page)
Recommend a brief comment explaining this.

https://codereview.chromium.org/23604005/diff/8001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/core/browser_options.py (right):

https://codereview.chromium.org/23604005/diff/8001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/browser_options.py:43: self.output_profile_path =
None
Not sure if this is a dumb idea, but can we just reuse the profile_dir member?

https://codereview.chromium.org/23604005/diff/8001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/page/profile_generator.py (right):

https://codereview.chromium.org/23604005/diff/8001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/profile_generator.py:24: os.pardir, os.pardir,
os.pardir, 'perf', 'profile_creators'))
Is this another good case for util.GetBaseDir()?

https://codereview.chromium.org/23604005/diff/8001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/profile_generator.py:64:
sys.stderr.write("Generated profile copied to: '%s'." % out_path)
Since this is going to stderr, let's make it clear this isn't an err.

'SUCCESS: Generated profile copied to...'

[commit-bot: I haz the power, 2013-08-28 17:49:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/23604005/13001

[commit-bot: I haz the power, 2013-08-28 17:50:01]

Failed to apply patch for tools/telemetry/telemetry/page/page_test_runner.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/telemetry/telemetry/page/page_test_runner.py
  Hunk #2 FAILED at 126.
  1 out of 2 hunks FAILED -- saving rejects to file
tools/telemetry/telemetry/page/page_test_runner.py.rej

Patch:       tools/telemetry/telemetry/page/page_test_runner.py
Index: tools/telemetry/telemetry/page/page_test_runner.py
diff --git a/tools/telemetry/telemetry/page/page_test_runner.py
b/tools/telemetry/telemetry/page/page_test_runner.py
index
623a5c81cd0e46d79d29f17d99c7b351de41c1f8..a882dc80e1f5d8e90eb95b1e2bd5acb085b9821e
100644
--- a/tools/telemetry/telemetry/page/page_test_runner.py
+++ b/tools/telemetry/telemetry/page/page_test_runner.py
@@ -7,7 +7,6 @@ import sys
 from telemetry import test as test_module
 from telemetry.core import browser_options
 from telemetry.core import discover
-from telemetry.core import profile_types
 from telemetry.page import page_test as page_test_module
 from telemetry.page import page_runner
 from telemetry.page import page_set
@@ -127,9 +126,6 @@ class PageTestRunner(object):
                     page_set_arg)
 
   def ParseCommandLine(self, args, base_dir, page_set_filenames):
-    # Need to collect profile creators before creating command line parser.
-    profile_types.FindProfileCreators(base_dir, base_dir)
-
     self._options = browser_options.BrowserOptions()
     self._parser = self._options.CreateParser(
         '%%prog [options] %s page_set' % self.test_class_name)

[commit-bot: I haz the power, 2013-08-28 18:28:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/23604005/25001

[commit-bot: I haz the power, 2013-08-29 01:34:09]

Change committed as 220157

[Dominik Grewe, 2013-09-02 09:15:18]

I think I may have found a small bug. See below:

https://chromiumcodereview.appspot.com/23604005/diff/25001/tools/telemetry/te...
File tools/telemetry/telemetry/core/chrome/android_browser_backend.py (right):

https://chromiumcodereview.appspot.com/23604005/diff/25001/tools/telemetry/te...
tools/telemetry/telemetry/core/chrome/android_browser_backend.py:273: if
self._options.output_profile_path:
This crashes with
AttributeError: 'AndroidBrowserBackend' object has no attribute '_options'

Should it be self.finder_options.output_profile_path instead?

[Dominik Grewe, 2013-09-02 10:43:46]

https://codereview.chromium.org/23604005/diff/25001/tools/telemetry/telemetry...
File tools/telemetry/telemetry/core/chrome/android_browser_backend.py (right):

https://codereview.chromium.org/23604005/diff/25001/tools/telemetry/telemetry...
tools/telemetry/telemetry/core/chrome/android_browser_backend.py:273: if
self._options.output_profile_path:
On 2013/09/02 09:15:18, Dominik Grewe wrote:
> This crashes with
> AttributeError: 'AndroidBrowserBackend' object has no attribute '_options'
> 
> Should it be self.finder_options.output_profile_path instead?

Because this bug caused the perf bots to fail I've uploaded a fix:
http://crrev.com/23866002.