tools/telemetry/telemetry/page/page_test_runner.py - Issue 23604005: [Telemetry] Implement dirty profile generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test_runner.py

Issue 23604005: [Telemetry] Implement dirty profile generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@generate_profile

Patch Set: Rebase against trunk Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/chrome/android_browser_backend.py ('K') | « tools/telemetry/telemetry/core/profile_types_unittest.py ('k') | tools/telemetry/telemetry/page/profile_creator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_test_runner.py

diff --git a/tools/telemetry/telemetry/page/page_test_runner.py b/tools/telemetry/telemetry/page/page_test_runner.py

index e9e66d338692a428cbc21a758b7838e3b849daa9..b594987cceed0be66d39c9050b90fd1e39c3731b 100644

--- a/tools/telemetry/telemetry/page/page_test_runner.py

+++ b/tools/telemetry/telemetry/page/page_test_runner.py

@@ -7,7 +7,6 @@ import sys

from telemetry import test as test_module

from telemetry.core import browser_options

from telemetry.core import discover

-from telemetry.core import profile_types

from telemetry.page import page_test as page_test_module

from telemetry.page import page_runner

from telemetry.page import page_set

@@ -127,9 +126,6 @@ class PageTestRunner(object):

page_set_arg)

def ParseCommandLine(self, args, base_dir, page_set_filenames):

- # Need to collect profile creators before creating command line parser.

- profile_types.FindProfileCreators(base_dir, base_dir)

self._options = browser_options.BrowserFinderOptions()

self._parser = self._options.CreateParser(

'%%prog [options] %s page_set' % self.test_class_name)