Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2360383003: Make SVG*StringList and SVGStringListTearOff scarcer (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SVG*StringList and SVGStringListTearOff scarcer (Primarily) because of their inclusion in the SVGTests interface, these two make their way into a lot more compilation units than has use for them. The principal access to this data is the SVGTests::isValid() method, so only the actual bindings should need any deeper insight into these. Shuffle declarations and definitions to make their inclusion more scarce. (From ~194 -> ~13 total dependencies for the latter, based on "ninja -t deps".) Committed: https://crrev.com/454771276058e585dbda30ff22f523f19e29492e Cr-Commit-Position: refs/heads/master@{#420614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTests.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTests.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewElement.cpp View 2 chunks +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
fs
4 years, 3 months ago (2016-09-23 08:04:48 UTC) #6
Stephen Chennney
lgtm. Thanks.
4 years, 3 months ago (2016-09-23 13:54:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360383003/1
4 years, 3 months ago (2016-09-23 14:04:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 14:09:25 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 14:11:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/454771276058e585dbda30ff22f523f19e29492e
Cr-Commit-Position: refs/heads/master@{#420614}

Powered by Google App Engine
This is Rietveld 408576698