Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2360353002: Remove obsolete getBufferSubData compatibility entry points. (Closed)

Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, blink-reviews, jam, haraken, darin-cc_chromium.org, piman+watch_chromium.org, yunchao, qiankun
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete getBufferSubData compatibility entry points. BUG=639145, 649250 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/f32c007a212163867271de976999a32a02161209 Cr-Commit-Position: refs/heads/master@{#420706}

Patch Set 1 #

Patch Set 2 : Preemptive rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Ken Russell (switch to Gerrit)
PTAL. Verified locally.
4 years, 3 months ago (2016-09-22 18:07:22 UTC) #4
Zhenyao Mo
On 2016/09/22 18:07:22, Ken Russell wrote: > PTAL. Verified locally. lgtm Thanks for cleaning this ...
4 years, 3 months ago (2016-09-22 19:47:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360353002/20001
4 years, 3 months ago (2016-09-23 17:55:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/303239)
4 years, 3 months ago (2016-09-23 19:37:59 UTC) #10
Ken Russell (switch to Gerrit)
On 2016/09/23 19:37:59, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-23 19:49:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360353002/20001
4 years, 3 months ago (2016-09-23 19:50:26 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 19:56:43 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 20:00:20 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f32c007a212163867271de976999a32a02161209
Cr-Commit-Position: refs/heads/master@{#420706}

Powered by Google App Engine
This is Rietveld 408576698