Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 236033002: Hide textarea placeholder text when showing autofill suggestion (Closed)

Created:
6 years, 8 months ago by Evan Stade
Modified:
6 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Hide textarea placeholder text when showing autofill suggestion BUG=362607 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171580

Patch Set 1 #

Patch Set 2 : now with layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
A LayoutTests/fast/forms/suggested-value-hides-placeholder.html View 1 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/suggested-value-hides-placeholder-expected.html View 1 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Evan Stade
6 years, 8 months ago (2014-04-11 22:11:08 UTC) #1
tkent
This change needs a layout test. We can make a reference test to compare a ...
6 years, 8 months ago (2014-04-14 00:34:17 UTC) #2
Evan Stade
how's this?
6 years, 8 months ago (2014-04-15 02:30:14 UTC) #3
tkent
lgtm
6 years, 8 months ago (2014-04-15 03:30:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/236033002/20001
6 years, 8 months ago (2014-04-15 03:30:24 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 03:31:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-15 03:31:07 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 8 months ago (2014-04-15 05:05:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/236033002/20001
6 years, 8 months ago (2014-04-15 05:05:51 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 05:09:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-15 05:09:11 UTC) #11
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-15 16:38:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/236033002/20001
6 years, 8 months ago (2014-04-15 16:38:38 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 16:39:28 UTC) #14
Message was sent while issue was closed.
Change committed as 171580

Powered by Google App Engine
This is Rietveld 408576698