Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: Source/core/html/HTMLTextAreaElement.h

Issue 236033002: Hide textarea placeholder text when showing autofill suggestion (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: now with layout test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/forms/suggested-value-hides-placeholder-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTextAreaElement.h
diff --git a/Source/core/html/HTMLTextAreaElement.h b/Source/core/html/HTMLTextAreaElement.h
index f33274c029a86b72eff36a8659691b09631c82c2..63ef906fa9d1232153d08954538e686e179245d0 100644
--- a/Source/core/html/HTMLTextAreaElement.h
+++ b/Source/core/html/HTMLTextAreaElement.h
@@ -81,6 +81,7 @@ private:
virtual bool supportsPlaceholder() const OVERRIDE { return true; }
virtual void updatePlaceholderText() OVERRIDE;
virtual bool isEmptyValue() const OVERRIDE { return value().isEmpty(); }
+ virtual bool isEmptySuggestedValue() const OVERRIDE FINAL { return suggestedValue().isEmpty(); }
virtual bool isOptionalFormControl() const OVERRIDE { return !isRequiredFormControl(); }
virtual bool isRequiredFormControl() const OVERRIDE { return isRequired(); }
« no previous file with comments | « LayoutTests/fast/forms/suggested-value-hides-placeholder-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698