chrome/browser/ntp_snippets/downloads/DEPS - Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ntp_snippets/downloads/DEPS

Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider. (Closed)

Patch Set: Marc's comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ntp_snippets/downloads/DEPS

diff --git a/chrome/browser/ntp_snippets/downloads/DEPS b/chrome/browser/ntp_snippets/downloads/DEPS

new file mode 100644

index 0000000000000000000000000000000000000000..dbe036ccf683e78eff3cd9421bd7d2cab4cd3595

--- /dev/null

+++ b/chrome/browser/ntp_snippets/downloads/DEPS

@@ -0,0 +1,3 @@

+include_rules = [

+ "+grit/components_strings.h",

Marc Treib 2016/10/11 12:07:39 Is this needed?! If the provider itself isn't in c

vitaliii 2016/10/13 08:43:04 Em, how to be with IDS_NTP_DOWNLOAD_SUGGESTIONS_SE

Marc Treib 2016/10/13 12:11:25 You could move that string into chrome/app/generat

vitaliii 2016/10/15 18:36:29 Done.