chrome/browser/ntp_snippets/downloads/DEPS - Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ntp_snippets/downloads/DEPS

Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider. (Closed)

Patch Set: Marc's comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ntp_snippets/content_suggestions_service_factory.cc ('K') | « chrome/browser/ntp_snippets/content_suggestions_service_factory.cc ('k') | chrome/browser/ntp_snippets/downloads/download_suggestions_provider.h » ('j') | chrome/browser/ntp_snippets/downloads/download_suggestions_provider.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+grit/components_strings.h",
	Marc Treib 2016/10/11 12:07:39 Is this needed?! If the provider itself isn't in c Is this needed?! If the provider itself isn't in components, then its strings shouldn't be there either. vitaliii 2016/10/13 08:43:04 Em, how to be with IDS_NTP_DOWNLOAD_SUGGESTIONS_SE Show quoted text On 2016/10/11 12:07:39, Marc Treib wrote: > Is this needed?! If the provider itself isn't in components, then its strings > shouldn't be there either. Em, how to be with IDS_NTP_DOWNLOAD_SUGGESTIONS_SECTION_HEADER? Marc Treib 2016/10/13 12:11:25 You could move that string into chrome/app/generat Show quoted text On 2016/10/13 08:43:04, vitaliii wrote: > On 2016/10/11 12:07:39, Marc Treib wrote: > > Is this needed?! If the provider itself isn't in components, then its strings > > shouldn't be there either. > > Em, how to be with IDS_NTP_DOWNLOAD_SUGGESTIONS_SECTION_HEADER? You could move that string into chrome/app/generated_resources.grd, where most of Chrome's strings are. No need for the string to be in components when the code that uses it isn't. vitaliii 2016/10/15 18:36:29 Done. Show quoted text On 2016/10/13 12:11:25, Marc Treib wrote: > On 2016/10/13 08:43:04, vitaliii wrote: > > On 2016/10/11 12:07:39, Marc Treib wrote: > > > Is this needed?! If the provider itself isn't in components, then its > strings > > > shouldn't be there either. > > > > Em, how to be with IDS_NTP_DOWNLOAD_SUGGESTIONS_SECTION_HEADER? > > You could move that string into chrome/app/generated_resources.grd, where most > of Chrome's strings are. No need for the string to be in components when the > code that uses it isn't. Done.
	3 ]

OLD	NEW