chrome/app/generated_resources.grd - Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider. (Closed)

Patch Set: rebase + Marc's comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 041ed9f481d88921a3750bf1b71c2c5e18597474..b0cec5e69f70d7b0593320d60dff9332d4647c77 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -447,6 +447,9 @@ are declared in build/common.gypi.

Did you mean to go to <ph name="SITE">$1<ex>http://intranetsite/</ex></ph>?

</message>

+ <message name="IDS_NTP_DOWNLOAD_SUGGESTIONS_SECTION_HEADER" desc="Header of the downloads section, which is a list of pages (or files) that the user downloaded, displayed as cards on the New Tab Page.">

Bernhard Bauer 2016/10/26 10:19:32 Can you move this message closer to the other NTP

vitaliii 2016/10/27 15:49:19 As it was discussed, I added a new "section" (or i

+ Downloads

+ </message>

Downloads

</message>

« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | chrome/browser/ntp_snippets/content_suggestions_service_factory.cc » ('J')