Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider. (Closed)
Patch Set: rebase + Marc's comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
diff --git a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
index cdfb5a0e495d3291a12293e47e3f70e32baead85..dd28f94622e70ea3bef459d73ea41b615be971e5 100644
--- a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
+++ b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
@@ -55,11 +55,13 @@
#include "chrome/browser/android/chrome_feature_list.h"
#include "chrome/browser/android/ntp/ntp_snippets_launcher.h"
#include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
+#include "chrome/browser/ntp_snippets/download_suggestions_provider.h"
#include "components/ntp_snippets/offline_pages/offline_page_proxy.h"
#include "components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h"
#include "components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h"
#include "components/offline_pages/offline_page_model.h"
+using content::DownloadManager;
using ntp_snippets::OfflinePageProxy;
using ntp_snippets::PhysicalWebPageSuggestionsProvider;
using ntp_snippets::RecentTabSuggestionsProvider;
@@ -104,6 +106,20 @@ void RegisterRecentTabProvider(
service, category_factory, offline_page_proxy, pref_service);
service->RegisterProvider(std::move(provider));
}
+
+void RegisterDownloadsProvider(
+ const scoped_refptr<OfflinePageProxy>& offline_page_proxy,
Bernhard Bauer 2016/10/26 10:19:32 Per https://chromium.googlesource.com/chromium/src
vitaliii 2016/10/27 15:49:19 Done.
+ DownloadManager* download_manager,
+ ContentSuggestionsService* service,
+ CategoryFactory* category_factory,
+ PrefService* pref_service) {
+ bool download_manager_ui_enabled =
+ base::FeatureList::IsEnabled(chrome::android::kDownloadsUiFeature);
+ auto provider = base::MakeUnique<DownloadSuggestionsProvider>(
+ service, category_factory, offline_page_proxy, download_manager,
+ pref_service, download_manager_ui_enabled);
+ service->RegisterProvider(std::move(provider));
+}
#endif // OS_ANDROID
void RegisterBookmarkProvider(BookmarkModel* bookmark_model,
@@ -245,6 +261,8 @@ KeyedService* ContentSuggestionsServiceFactory::BuildServiceInstanceFor(
OfflinePageModelFactory::GetForBrowserContext(profile);
scoped_refptr<OfflinePageProxy> offline_page_proxy(
new OfflinePageProxy(offline_page_model));
+ DownloadManager* download_manager =
+ content::BrowserContext::GetDownloadManager(profile);
#endif // OS_ANDROID
BookmarkModel* bookmark_model =
BookmarkModelFactory::GetForBrowserContext(profile);
@@ -263,6 +281,11 @@ KeyedService* ContentSuggestionsServiceFactory::BuildServiceInstanceFor(
RegisterRecentTabProvider(offline_page_proxy, service, category_factory,
pref_service);
}
+
+ if (base::FeatureList::IsEnabled(ntp_snippets::kDownloadSuggestionsFeature)) {
+ RegisterDownloadsProvider(offline_page_proxy, download_manager, service,
+ category_factory, pref_service);
+ }
#endif // OS_ANDROID
// |bookmark_model| can be null in tests.

Powered by Google App Engine
This is Rietveld 408576698