[MD History] Hide empty synced device cards.

[MD History] Hide empty synced device cards.

This CL hides synced device cards if they have no tabs in them which can
happen during search.

BUG=635749
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/09e8eff19f8d9a63beff3514631f4593e0de2420
Cr-Commit-Position: refs/heads/master@{#421086}

[calamity, 2016-09-22 05:45:49]

Description was changed from

==========
[MD History] Hide empty synced device cards.

This CL hides synced device cards if they have no tabs in them which can
happen during search.

BUG=635749
==========

to

==========
[MD History] Hide empty synced device cards.

This CL hides synced device cards if they have no tabs in them which can
happen during search.

BUG=635749
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-09-22 05:56:15]

Description was changed from

==========
[MD History] Hide empty synced device cards.

This CL hides synced device cards if they have no tabs in them which can
happen during search.

BUG=635749
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Hide empty synced device cards.

This CL hides synced device cards if they have no tabs in them which can
happen during search.

BUG=635749
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-09-22 05:58:29]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-09-22 06:58:50]

lgtm wnonbistytftatl

https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_manager.js:243: device =
this.createInternalDevice_(sessionList[i]);
Nit: Add `var`

https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_manager.js:252: device =
this.createInternalDevice_(sessionList[i]);
Nit: Here too

(or declare `var device;` at the top of the method. Whichever you prefer)

[calamity, 2016-09-22 07:52:53]

https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_manager.js:243: device =
this.createInternalDevice_(sessionList[i]);
On 2016/09/22 06:58:50, tsergeant wrote:
> Nit: Add `var`

Done.

https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_manager.js:252: device =
this.createInternalDevice_(sessionList[i]);
On 2016/09/22 06:58:50, tsergeant wrote:
> Nit: Here too
> 
> (or declare `var device;` at the top of the method. Whichever you prefer)

Done.

[calamity, 2016-09-22 07:52:58]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-09-22 07:52:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2360193002/#ps20001
(title: "add var")

[commit-bot: I haz the power, 2016-09-22 07:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 07:53:14]

This CL has an open dependency (Issue 2339523004 Patch 140001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[tsergeant, 2016-09-23 01:06:13]

On 2016/09/22 07:53:14, commit-bot: I haz the power wrote:
> This CL has an open dependency (Issue 2339523004 Patch 140001). Please resolve
> the dependency and try again.
> If you are sure that there is no real dependency, please use one of the
options
> listed in https://goo.gl/9Es4OR to land the CL.

Dependent on...app list? Golly, your local setup is weird.

[calamity, 2016-09-26 07:15:18]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-09-26 07:15:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 07:17:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 07:17:37]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[calamity, 2016-09-27 01:04:01]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 01:04:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 02:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 02:33:29]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-09-27 02:40:36]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-09-27 02:40:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2360193002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-27 02:41:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 02:46:52]

Description was changed from

==========
[MD History] Hide empty synced device cards.

This CL hides synced device cards if they have no tabs in them which can
happen during search.

BUG=635749
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Hide empty synced device cards.

This CL hides synced device cards if they have no tabs in them which can
happen during search.

BUG=635749
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-27 02:46:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 02:49:08]

Description was changed from

==========
[MD History] Hide empty synced device cards.

This CL hides synced device cards if they have no tabs in them which can
happen during search.

BUG=635749
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Hide empty synced device cards.

This CL hides synced device cards if they have no tabs in them which can
happen during search.

BUG=635749
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/09e8eff19f8d9a63beff3514631f4593e0de2420
Cr-Commit-Position: refs/heads/master@{#421086}
==========

[commit-bot: I haz the power, 2016-09-27 02:49:09]

Patchset 3 (id:??) landed as
https://crrev.com/09e8eff19f8d9a63beff3514631f4593e0de2420
Cr-Commit-Position: refs/heads/master@{#421086}