Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2360193002: [MD History] Hide empty synced device cards. (Closed)

Created:
4 years, 3 months ago by calamity
Modified:
4 years, 2 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Hide empty synced device cards. This CL hides synced device cards if they have no tabs in them which can happen during search. BUG=635749 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/09e8eff19f8d9a63beff3514631f4593e0de2420 Cr-Commit-Position: refs/heads/master@{#421086}

Patch Set 1 #

Total comments: 4

Patch Set 2 : add var #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M chrome/browser/resources/md_history/lazy_load.crisper.js View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.js View 1 2 chunks +11 lines, -7 lines 0 comments Download
M chrome/test/data/webui/md_history/history_synced_tabs_test.js View 1 chunk +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (16 generated)
calamity
4 years, 3 months ago (2016-09-22 05:58:29 UTC) #4
tsergeant
lgtm wnonbistytftatl https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md_history/synced_device_manager.js File chrome/browser/resources/md_history/synced_device_manager.js (right): https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md_history/synced_device_manager.js#newcode243 chrome/browser/resources/md_history/synced_device_manager.js:243: device = this.createInternalDevice_(sessionList[i]); Nit: Add `var` https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md_history/synced_device_manager.js#newcode252 ...
4 years, 3 months ago (2016-09-22 06:58:50 UTC) #5
calamity
https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md_history/synced_device_manager.js File chrome/browser/resources/md_history/synced_device_manager.js (right): https://codereview.chromium.org/2360193002/diff/1/chrome/browser/resources/md_history/synced_device_manager.js#newcode243 chrome/browser/resources/md_history/synced_device_manager.js:243: device = this.createInternalDevice_(sessionList[i]); On 2016/09/22 06:58:50, tsergeant wrote: > ...
4 years, 3 months ago (2016-09-22 07:52:53 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2339523004 Patch 140001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-22 07:53:14 UTC) #10
tsergeant
On 2016/09/22 07:53:14, commit-bot: I haz the power wrote: > This CL has an open ...
4 years, 2 months ago (2016-09-23 01:06:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360193002/20001
4 years, 2 months ago (2016-09-26 07:15:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/74863) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-26 07:17:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360193002/40001
4 years, 2 months ago (2016-09-27 02:41:19 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-27 02:46:53 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 02:49:09 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/09e8eff19f8d9a63beff3514631f4593e0de2420
Cr-Commit-Position: refs/heads/master@{#421086}

Powered by Google App Engine
This is Rietveld 408576698