Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 2360103002: Removing unnecessary context menu logic (Closed)
Patch Set: fixed nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
index 7f4d369933bac7ea276ed54faf9baa710ed572aa..10033037aa882c4758f45bd48e8a20623ee9705f 100644
--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
@@ -88,8 +88,6 @@ import java.util.UUID;
// Lazily created proxy observer for handling all Java-based WebContentsObservers.
private WebContentsObserverProxy mObserverProxy;
- private boolean mContextMenuOpened;
-
private WebContentsImpl(
long nativeWebContentsAndroid, NavigationController navigationController) {
mNativeWebContentsAndroid = nativeWebContentsAndroid;
@@ -436,24 +434,6 @@ import java.util.UUID;
srcRect.left, srcRect.top, srcRect.width(), srcRect.height());
}
- @Override
- public void onContextMenuOpened() {
- mContextMenuOpened = true;
- }
-
- @Override
- public void onContextMenuClosed() {
- if (!mContextMenuOpened) {
- return;
- } else {
- mContextMenuOpened = false;
- }
-
- if (mNativeWebContentsAndroid != 0) {
- nativeOnContextMenuClosed(mNativeWebContentsAndroid);
- }
- }
-
@CalledByNative
private void onGetContentBitmapFinished(ContentBitmapCallback callback, Bitmap bitmap,
int response) {
@@ -555,7 +535,6 @@ import java.util.UUID;
private native void nativeGetContentBitmap(long nativeWebContentsAndroid,
ContentBitmapCallback callback, Bitmap.Config config, float scale,
float x, float y, float width, float height);
- private native void nativeOnContextMenuClosed(long nativeWebContentsAndroid);
private native void nativeReloadLoFiImages(long nativeWebContentsAndroid);
private native int nativeDownloadImage(long nativeWebContentsAndroid,
String url, boolean isFavicon, int maxBitmapSize,

Powered by Google App Engine
This is Rietveld 408576698