chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2360103002: Removing unnecessary context menu logic

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2360103002: Removing unnecessary context menu logic (Closed)

Patch Set: fixed nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « android_webview/native/aw_web_contents_view_delegate.cc ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index bd49b620ad30cf759092995567602288d537da25..19680d122ac6ce4b51bed244080d4bee040de529 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -1782,24 +1782,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

mContextMenuCloseObservers.removeObserver(callback);

}

- /**

- * @see Activity#onContextMenuClosed(Menu)

- */

- @Override

- public void onContextMenuClosed(Menu menu) {

PEConn 2016/09/28 13:16:48 Was there any reason to remove this code? We need

boliu 2016/09/28 15:36:40 Yeah, probably should have removed the bit calling

amaralp 2016/09/28 18:04:44 Yeah, you are right. Here is a patch to fix it: ht

amaralp 2016/09/28 18:33:23 Looks like this was already fixed in https://coder

- for (Callback<Menu> callback : mContextMenuCloseObservers) {

- callback.onResult(menu);

- }

- // TODO(peconn): See if we can make WebContents use the ObserverList.

- final Tab currentTab = getActivityTab();

- if (currentTab == null) return;

- WebContents webContents = currentTab.getWebContents();

- if (webContents == null) return;

- webContents.onContextMenuClosed();

- }

private void enableHardwareAcceleration() {

// HW acceleration is disabled in the manifest. Enable it only on high-end devices.

if (!SysUtils.isLowEndDevice()) {