Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2381473002: 📰 Block touch interaction when a context menu is shown (Closed)

Created:
4 years, 2 months ago by dgn
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer, PEConn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org, amaralp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Block touch interaction when a context menu is shown Fix 2 issues: - The contextMenuClose listeners were not called since https://codereview.chromium.org/2360103002, resulting in unresponsive NTP after opening a context menu - The touch interactions for the RecyclerView itself were ignored when the context menu was open, but were still propagated to children who would handle them a usual. BUG=650153, 650878 Committed: https://crrev.com/ccf7a497c972ed6ab3a041ac99a68bd87481a6ad Cr-Commit-Position: refs/heads/master@{#421514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
dgn
PTAL
4 years, 2 months ago (2016-09-28 10:24:49 UTC) #5
dgn
This should also be applied to the NTP Tiles code, but it's using a completely ...
4 years, 2 months ago (2016-09-28 12:20:38 UTC) #8
PEConn
LGTM
4 years, 2 months ago (2016-09-28 13:51:57 UTC) #9
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-09-28 13:58:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381473002/1
4 years, 2 months ago (2016-09-28 14:09:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 14:16:48 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 14:20:30 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccf7a497c972ed6ab3a041ac99a68bd87481a6ad
Cr-Commit-Position: refs/heads/master@{#421514}

Powered by Google App Engine
This is Rietveld 408576698