Removing unnecessary context menu logic

android_webview/native/aw_web_contents_view_delegate.cc

Index: android_webview/native/aw_web_contents_view_delegate.cc
diff --git a/android_webview/native/aw_web_contents_view_delegate.cc b/android_webview/native/aw_web_contents_view_delegate.cc
index bc1605996f703d5315dec643ed9be84b726aa0a3..94f582aab962264549fb4be713e9058f55ea998c 100644
--- a/android_webview/native/aw_web_contents_view_delegate.cc
+++ b/android_webview/native/aw_web_contents_view_delegate.cc
@@ -43,13 +43,11 @@ void AwWebContentsViewDelegate::ShowContextMenu(
   if (params.is_editable && params.selection_text.empty()) {

[boliu, 2016/09/22 18:48:36]

what if this check fails though?

[amaralp, 2016/09/22 18:58:54]

Wouldn't the behavior be the same as before the patch? The menu wouldn't be
shown.

[boliu, 2016/09/22 19:02:46]

it used to call NotifyContextMenuClosed if ths check fails, presumably to match
this call. is that not important?

[amaralp, 2016/09/22 19:15:30]

Previously NotifyContextMenuClosed would resume the blinking of the caret but
since on Android the blinking is not suspended this is unnecessary.

     content::ContentViewCore* content_view_core =
         content::ContentViewCore::FromWebContents(web_contents_);
-    if (content_view_core &&
-        content_view_core->ShowPastePopup(params.selection_start.x(),
-                                          params.selection_start.y())) {
-      return;
+    if (content_view_core) {
+      content_view_core->ShowPastePopup(params.selection_start.x(),
+                                        params.selection_start.y());
     }
   }
-  web_contents_->NotifyContextMenuClosed(content::CustomContextMenuContext());
 }
 
 }  // namespace android_webview