Removing unnecessary context menu logic

android_webview/native/aw_web_contents_view_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/aw_web_contents_view_delegate.h"
 
 #include "content/public/browser/android/content_view_core.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/context_menu_params.h"
 
@@ skipping 22 matching lines @@
 }
 
 void AwWebContentsViewDelegate::ShowContextMenu(
     content::RenderFrameHost* render_frame_host,
     const content::ContextMenuParams& params) {
   // TODO(boliu): Large blocks of this function are identical with
   // ChromeWebContentsViewDelegateAndroid::ShowContextMenu. De-dup this if
   // possible.
 
   // Display paste pop-up only when selection is empty and editable.
   if (params.is_editable && params.selection_text.empty()) {

[boliu, 2016/09/22 18:48:36]

what if this check fails though?

[amaralp, 2016/09/22 18:58:54]

Wouldn't the behavior be the same as before the patch? The menu wouldn't be
shown.

[boliu, 2016/09/22 19:02:46]

it used to call NotifyContextMenuClosed if ths check fails, presumably to match
this call. is that not important?

[amaralp, 2016/09/22 19:15:30]

Previously NotifyContextMenuClosed would resume the blinking of the caret but
since on Android the blinking is not suspended this is unnecessary.

     content::ContentViewCore* content_view_core =
         content::ContentViewCore::FromWebContents(web_contents_);
-    if (content_view_core &&
-        content_view_core->ShowPastePopup(params.selection_start.x(),
-                                          params.selection_start.y())) {
-      return;
+    if (content_view_core) {
+      content_view_core->ShowPastePopup(params.selection_start.x(),
+                                        params.selection_start.y());
     }
   }
-  web_contents_->NotifyContextMenuClosed(content::CustomContextMenuContext());
 }
 
 }  // namespace android_webview