Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 23601018: Fix ParameterMirror.toString and FunctionTypeMirror.toString. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address long lines Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index acd7f0550e2d41c579ddcc36f9b418beb2811aec..844b6a82d93b40f465ce0aafba07ac675772326b 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -49,24 +49,37 @@ Map<Symbol, dynamic> _convertStringToSymbolMap(Map<String, dynamic> map) {
String _makeSignatureString(TypeMirror returnType,
List<ParameterMirror> parameters) {
StringBuffer buf = new StringBuffer();
- buf.write(_n(returnType.qualifiedName));
- buf.write(' (');
- bool found_optional_param = false;
+ buf.write('(');
+ bool found_optional_positional = false;
+ bool found_optional_named = false;
+
for (int i = 0; i < parameters.length; i++) {
var param = parameters[i];
- if (param.isOptional && !found_optional_param) {
+ if (param.isOptional && param.isNamed && !found_optional_named) {
+ buf.write('{');
+ found_optional_named = true;
+ }
+ if (param.isOptional && !param.isNamed && !found_optional_positional) {
buf.write('[');
- found_optional_param = true;
+ found_optional_positional = true;
+ }
+ if (param.isNamed) {
+ buf.write(_n(param.simpleName));
+ buf.write(': ');
}
buf.write(_n(param.type.qualifiedName));
if (i < (parameters.length - 1)) {
buf.write(', ');
}
}
- if (found_optional_param) {
+ if (found_optional_named) {
+ buf.write('}');
+ }
+ if (found_optional_positional) {
buf.write(']');
}
- buf.write(')');
+ buf.write(') -> ');
+ buf.write(_n(returnType.qualifiedName));
return buf.toString();
}
@@ -1266,6 +1279,8 @@ class _LocalParameterMirrorImpl extends _LocalVariableMirrorImpl
return _type;
}
+ String toString() => "ParameterMirror on '${_n(simpleName)}'";
+
static Type _ParameterMirror_type(_reflectee, _position)
native "ParameterMirror_type";
}
« no previous file with comments | « no previous file | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698