Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 23601018: Fix ParameterMirror.toString and FunctionTypeMirror.toString. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address long lines Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart
index ee760b71d1ed365aad5c7fc35cd0644c9a2ab049..deb2faa2297f2d0e56eac9f45a8ebc4fa2d66dd6 100644
--- a/sdk/lib/_internal/lib/js_mirrors.dart
+++ b/sdk/lib/_internal/lib/js_mirrors.dart
@@ -1506,8 +1506,8 @@ class JsFunctionTypeMirror implements FunctionTypeMirror {
var sep = '';
if (_hasArguments) {
for (var argument in _arguments) {
- s += runtimeTypeToString(argument);
s += sep;
+ s += runtimeTypeToString(argument);
sep = ', ';
}
}
@@ -1515,8 +1515,8 @@ class JsFunctionTypeMirror implements FunctionTypeMirror {
s += '$sep[';
sep = '';
for (var argument in _optionalArguments) {
- s += runtimeTypeToString(argument);
s += sep;
+ s += runtimeTypeToString(argument);
sep = ', ';
}
s += ']';
@@ -1525,9 +1525,9 @@ class JsFunctionTypeMirror implements FunctionTypeMirror {
s += '$sep{';
sep = '';
for (var name in extractKeys(_namedArguments)) {
+ s += sep;
s += '$name: ';
s += runtimeTypeToString(JS('', '#[#]', _namedArguments, name));
- s += sep;
sep = ', ';
}
s += '}';
« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698