Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2360083004: Changed VRLayer's left/rightBounds to match the spec (Closed)

Created:
4 years, 3 months ago by bajones
Modified:
4 years, 3 months ago
Reviewers:
girard
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed VRLayer's left/rightBounds to match the spec BUG=389343 Committed: https://crrev.com/a8cfe83a927a2e014116dd1870d498a79cfe8809 Cr-Commit-Position: refs/heads/master@{#420270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 3 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRLayer.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bajones
Updating based on conversation in https://github.com/w3c/webvr/issues/95 PTAL!
4 years, 3 months ago (2016-09-21 23:19:51 UTC) #2
girard
lgtm
4 years, 3 months ago (2016-09-22 04:18:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360083004/1
4 years, 3 months ago (2016-09-22 04:19:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 05:54:35 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 05:56:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8cfe83a927a2e014116dd1870d498a79cfe8809
Cr-Commit-Position: refs/heads/master@{#420270}

Powered by Google App Engine
This is Rietveld 408576698