Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: extensions/browser/api/hid/hid_api.cc

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)
Patch Set: lazyboy's Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/hid/hid_api.cc
diff --git a/extensions/browser/api/hid/hid_api.cc b/extensions/browser/api/hid/hid_api.cc
index c93f6e9c6ef25bf7ac99f35dd268e8557c30ae3c..938b528adae313b736d5fca8c3490408a8013429 100644
--- a/extensions/browser/api/hid/hid_api.cc
+++ b/extensions/browser/api/hid/hid_api.cc
@@ -35,7 +35,7 @@
#define EXTENSION_FUNCTION_VALIDATE_RETURN_FALSE_ON_ERROR(test) \
do { \
if (!(test)) { \
- this->bad_message_ = true; \
+ this->set_bad_message(true); \
return false; \
} \
} while (0)
@@ -250,9 +250,7 @@ HidConnectionIoFunction::~HidConnectionIoFunction() {
}
ExtensionFunction::ResponseAction HidConnectionIoFunction::Run() {
- if (!ValidateParameters()) {
- return RespondNow(Error(error_));
- }
+ EXTENSION_FUNCTION_VALIDATE(ValidateParameters());
ApiResourceManager<HidConnectionResource>* connection_manager =
ApiResourceManager<HidConnectionResource>::Get(browser_context());

Powered by Google App Engine
This is Rietveld 408576698