[Extensions] Isolate ExtensionFunction results_ and error_

extensions/browser/api/hid/hid_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/hid/hid_api.h"
 
 #include <stdint.h>
 
 #include <string>
 #include <utility>
@@ skipping 17 matching lines @@
 //
 // With C++11, this is problematic since a smart pointer that uses explicit
 // operator bool won't allow this conversion, since it's not in a context (such
 // as a conditional) where a contextual conversion to bool would be allowed.
 // TODO(rdevlin.cronin): restructure this code to remove the need for the
 // additional macro.
 #ifdef NDEBUG
 #define EXTENSION_FUNCTION_VALIDATE_RETURN_FALSE_ON_ERROR(test) \
   do {                                                          \
     if (!(test)) {                                              \
-      this->bad_message_ = true;                                \
+      this->set_bad_message(true);                              \
       return false;                                             \
     }                                                           \
   } while (0)
 #else  // NDEBUG
 #define EXTENSION_FUNCTION_VALIDATE_RETURN_FALSE_ON_ERROR(test) CHECK(test)
 #endif  // NDEBUG
 
 namespace hid = extensions::api::hid;
 
 using device::HidConnection;
@@ skipping 194 matching lines @@
   return RespondNow(NoArguments());
 }
 
 HidConnectionIoFunction::HidConnectionIoFunction() {
 }
 
 HidConnectionIoFunction::~HidConnectionIoFunction() {
 }
 
 ExtensionFunction::ResponseAction HidConnectionIoFunction::Run() {
-  if (!ValidateParameters()) {
-    return RespondNow(Error(error_));
-  }
+  EXTENSION_FUNCTION_VALIDATE(ValidateParameters());
 
   ApiResourceManager<HidConnectionResource>* connection_manager =
       ApiResourceManager<HidConnectionResource>::Get(browser_context());
   CHECK(connection_manager);
 
   HidConnectionResource* resource =
       connection_manager->Get(extension_id(), connection_id_);
   if (!resource) {
     return RespondNow(Error(kErrorConnectionNotFound));
   }
@@ skipping 114 matching lines @@
 
 void HidSendFeatureReportFunction::OnFinished(bool success) {
   if (success) {
     Respond(NoArguments());
   } else {
     Respond(Error(kErrorTransfer));
   }
 }
 
 }  // namespace extensions