chrome/browser/extensions/api/inline_install_private/inline_install_private_api.cc - Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/inline_install_private/inline_install_private_api.cc

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)

Patch Set: lazyboy's Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/browsing_data/browsing_data_api.cc ('k') | chrome/browser/extensions/api/input_ime/input_ime_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/inline_install_private/inline_install_private_api.cc

diff --git a/chrome/browser/extensions/api/inline_install_private/inline_install_private_api.cc b/chrome/browser/extensions/api/inline_install_private/inline_install_private_api.cc

index e85b190cece76961f2edf9f9dd3146ee912b23a4..870613d80e382edf0d2279eb168de78e9e887129 100644

--- a/chrome/browser/extensions/api/inline_install_private/inline_install_private_api.cc

+++ b/chrome/browser/extensions/api/inline_install_private/inline_install_private_api.cc

@@ -116,14 +116,10 @@ InlineInstallPrivateInstallFunction::Run() {

return RespondNow(CreateResponse("Already installed",

webstore_install::OTHER_ERROR));

- scoped_refptr<Installer> installer =

- new Installer(

- params->id,

- source_url_,

- Profile::FromBrowserContext(browser_context()),

- base::Bind(

- &InlineInstallPrivateInstallFunction::InstallerCallback,

- this));

+ scoped_refptr<Installer> installer = new Installer(

+ params->id, source_url(), Profile::FromBrowserContext(browser_context()),

+ base::Bind(&InlineInstallPrivateInstallFunction::InstallerCallback,

+ this));

installer->BeginInstall();

return RespondLater();