[Extensions] Isolate ExtensionFunction results_ and error_

chrome/browser/extensions/api/inline_install_private/inline_install_private_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/inline_install_private/inline_install_private_api.h"
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/extensions/webstore_install_with_prompt.h"
@@ skipping 98 matching lines @@
   content::WebContents* web_contents = GetAssociatedWebContents();
   if (!web_contents)
     return RespondNow(CreateResponse("Must be called from a foreground page",
                                      webstore_install::NOT_PERMITTED));
 
   ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context());
   if (registry->GetExtensionById(params->id, ExtensionRegistry::EVERYTHING))
     return RespondNow(CreateResponse("Already installed",
                                      webstore_install::OTHER_ERROR));
 
-  scoped_refptr<Installer> installer =
-      new Installer(
-          params->id,
-          source_url_,
-          Profile::FromBrowserContext(browser_context()),
-          base::Bind(
-              &InlineInstallPrivateInstallFunction::InstallerCallback,
-              this));
+  scoped_refptr<Installer> installer = new Installer(
+      params->id, source_url(), Profile::FromBrowserContext(browser_context()),
+      base::Bind(&InlineInstallPrivateInstallFunction::InstallerCallback,
+                 this));
   installer->BeginInstall();
 
   return RespondLater();
 }
 
 void InlineInstallPrivateInstallFunction::InstallerCallback(
     bool success,
     const std::string& error,
     webstore_install::Result result) {
 
   Respond(CreateResponse(success ? std::string() : error, result));
 }
 
 ExtensionFunction::ResponseValue
 InlineInstallPrivateInstallFunction::CreateResponse(
     const std::string& error, webstore_install::Result result) {
   return ArgumentList(api::inline_install_private::Install::Results::Create(
       error,
       api::webstore::kInstallResultCodes[result]));
 }
 
 }  // namespace extensions