extensions/browser/api/management/management_api_delegate.h - Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/management/management_api_delegate.h

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)

Patch Set: errorwithargs Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/management/management_api_delegate.h

diff --git a/extensions/browser/api/management/management_api_delegate.h b/extensions/browser/api/management/management_api_delegate.h

index 4fec7b795e3ad6cb437622870854a7b32db605d1..e6dc0b4b11ac0c4be78eb478ccdeb7485189fe50 100644

--- a/extensions/browser/api/management/management_api_delegate.h

+++ b/extensions/browser/api/management/management_api_delegate.h

@@ -114,7 +114,8 @@ class ManagementAPIDelegate {

// Creates an app shortcut.

virtual bool CreateAppShortcutFunctionDelegate(

ManagementCreateAppShortcutFunction* function,

- const Extension* extension) const = 0;

+ const Extension* extension,

+ std::string* error) const = 0;

// Forwards the call to launch_util::SetLaunchType in chrome.

virtual void SetLaunchType(content::BrowserContext* context,