Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Unified Diff: extensions/browser/api/management/management_api.cc

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)
Patch Set: errorwithargs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/management/management_api.cc
diff --git a/extensions/browser/api/management/management_api.cc b/extensions/browser/api/management/management_api.cc
index 60180c5dd49a3c464c7dab6637e7206950362204..fb4c4198ce9f6de6fd2ed80b2dfdc7e8df4c7539 100644
--- a/extensions/browser/api/management/management_api.cc
+++ b/extensions/browser/api/management/management_api.cc
@@ -678,12 +678,15 @@ bool ManagementCreateAppShortcutFunction::RunAsync() {
return true;
}
+ std::string error;
if (ManagementAPI::GetFactoryInstance()
->Get(browser_context())
->GetDelegate()
- ->CreateAppShortcutFunctionDelegate(this, extension)) {
+ ->CreateAppShortcutFunctionDelegate(this, extension, &error)) {
// Matched with a Release() in OnCloseShortcutPrompt().
AddRef();
+ } else {
+ SetError(error);
}
// Response is sent async in OnCloseShortcutPrompt().

Powered by Google App Engine
This is Rietveld 408576698