chrome/test/data/extensions/api_test/permissions/optional_retain_gesture/background.js - Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/permissions/optional_retain_gesture/background.js

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)

Patch Set: errorwithargs Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/chrome_extension_function.h ('K') | « chrome/test/data/extensions/api_test/permissions/host_subsets/background.js ('k') | extensions/browser/api/execute_code_function.cc » ('j') | extensions/browser/api/web_request/web_request_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/permissions/optional_retain_gesture/background.js

diff --git a/chrome/test/data/extensions/api_test/permissions/optional_retain_gesture/background.js b/chrome/test/data/extensions/api_test/permissions/optional_retain_gesture/background.js

index 1062db97b5f0ad225097ebaf92ffe28a25ecf0a9..e521552424166307f477665a388b560d044e5d0d 100644

--- a/chrome/test/data/extensions/api_test/permissions/optional_retain_gesture/background.js

+++ b/chrome/test/data/extensions/api_test/permissions/optional_retain_gesture/background.js

@@ -55,7 +55,7 @@ chrome.test.getConfig(function(config) {

{permissions: ['bookmarks']},

function(granted1) {

if (chrome.runtime.lastError) {

- chrome.test.assertFalse(granted1);

+ chrome.test.assertFalse(!!granted1);

chrome.test.assertEq(chrome.runtime.lastError.message,

GESTURE_ERROR);

chrome.test.succeed();