chrome/test/data/extensions/api_test/permissions/host_subsets/background.js - Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/permissions/host_subsets/background.js

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)

Patch Set: errorwithargs Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/chrome_extension_function.h ('K') | « chrome/test/data/extensions/api_test/permissions/file_access_no/background.js ('k') | chrome/test/data/extensions/api_test/permissions/optional_retain_gesture/background.js » ('j') | extensions/browser/api/web_request/web_request_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/permissions/host_subsets/background.js

diff --git a/chrome/test/data/extensions/api_test/permissions/host_subsets/background.js b/chrome/test/data/extensions/api_test/permissions/host_subsets/background.js

index 3957bface9ed4840f140331ae64bf3693df19d59..d140496011258a1457fb1900f58c9304e3f68025 100644

--- a/chrome/test/data/extensions/api_test/permissions/host_subsets/background.js

+++ b/chrome/test/data/extensions/api_test/permissions/host_subsets/background.js

@@ -65,7 +65,7 @@ function requestHost(host, expectedGranted, expectedError) {

"Access to " + host + " was not granted, but should have been");

} else {

test.assertFalse(

- granted,

+ !!granted,

"Access to " + host + " was granted, but should not have been");

}

checkGrantedHosts(callback);